Skip to content

No default boundary conditions#286

Merged
JoshuaLampert merged 8 commits intomainfrom
no-default-bc
Feb 28, 2026
Merged

No default boundary conditions#286
JoshuaLampert merged 8 commits intomainfrom
no-default-bc

Conversation

@JoshuaLampert
Copy link
Copy Markdown
Member

@JoshuaLampert JoshuaLampert commented Feb 28, 2026

See #284 (comment). Looks like we already always explicitly passed boundary conditions.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 28, 2026 •
edited
Loading

Benchmark Results (Julia v1.10)

Time benchmarks
main 6f306b5... main / 6f306b5...
bbm_1d/bbm_1d_basic.jl - rhs!: 13.8 ± 0.25 μs 14 ± 0.31 μs 0.989 ± 0.028
bbm_1d/bbm_1d_fourier.jl - rhs!: 0.225 ± 0.31 ms 0.535 ± 0.01 ms 0.421 ± 0.58
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 0.0808 ± 0.00026 ms 0.0811 ± 0.00023 ms 0.997 ± 0.0043
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 0.034 ± 0.00045 ms 0.0339 ± 0.0005 ms 1 ± 0.02
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 27.2 ± 0.5 μs 27.2 ± 0.47 μs 0.999 ± 0.025
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 0.0488 ± 0.00062 ms 0.0483 ± 0.00073 ms 1.01 ± 0.02
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 4.24 ± 0.03 μs 4.28 ± 0.041 μs 0.991 ± 0.012
kdv_1d/kdv_1d_basic.jl - rhs!: 1.38 ± 0.02 μs 1.41 ± 0.01 μs 0.979 ± 0.016
kdv_1d/kdv_1d_implicit.jl - rhs!: 1.42 ± 0.031 μs 1.46 ± 0.01 μs 0.973 ± 0.022
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.197 ± 0.0076 ms 0.202 ± 0.0093 ms 0.974 ± 0.058
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.146 ± 0.0038 ms 0.149 ± 0.0054 ms 0.978 ± 0.044
time_to_load 2.25 ± 0.036 s 2.28 ± 0.0059 s 0.987 ± 0.016
Memory benchmarks
main 6f306b5... main / 6f306b5...
bbm_1d/bbm_1d_basic.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_1d/bbm_1d_fourier.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 5 allocs: 1.17 kB 5 allocs: 1.17 kB 1
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 10 allocs: 8.62 kB 10 allocs: 8.62 kB 1
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_basic.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_implicit.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.075 k allocs: 0.66 MB 0.075 k allocs: 0.66 MB 1
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.042 k allocs: 0.315 MB 0.042 k allocs: 0.315 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

github-actions[bot]
github-actions bot reviewed Feb 28, 2026
View reviewed changes
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@JoshuaLampert
Copy link
Copy Markdown
Member Author

JoshuaLampert commented Feb 28, 2026

I also noticed we have some examples with a lot of output due to the AnalysisCallback. So I increased the interval for the ones with the most output to reduce clutter. With this, the number of lines in the CI logs went down from ~28.5 k lines to ~12.5 k lines.

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Feb 28, 2026

Pull Request Test Coverage Report for Build 22521950316

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on no-default-bc at 98.48%
Totals Coverage Status
Change from base Build 22516477323: 98.5%
Covered Lines: 2332
Relevant Lines: 2368
💛 - Coveralls

ranocha
ranocha approved these changes Feb 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaLampert JoshuaLampert merged commit 05d88f0 into main Feb 28, 2026
18 of 19 checks passed
@JoshuaLampert JoshuaLampert deleted the no-default-bc branch February 28, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ranocha ranocha ranocha approved these changes

Assignees

No one assigned

Labels

breaking

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JoshuaLampert @codecov-commenter @coveralls @ranocha